Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Get rid of felt_into_bool and bool_into_felt #1067

Open
piwonskp opened this issue May 23, 2023 · 0 comments
Open

Get rid of felt_into_bool and bool_into_felt #1067

piwonskp opened this issue May 23, 2023 · 0 comments
Milestone

Comments

@piwonskp
Copy link
Contributor

Serialization code should be refactored to use generic functions within https://github.com/NethermindEth/warp/blob/cairo-1.0/warplib/src/warp_memory/accessors.cairo#L95 instead of using conversion functions and then writing to the memory.

After refactoring felt_into_bool and bool_into_felt (https://github.com/NethermindEth/warp/blob/cairo-1.0/warplib/src/conversions/integer_conversions.cairo#LL20C40-L20C40) should be removed

@piwonskp piwonskp added this to the Cairo 1.0 milestone May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant