Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write docs for v12.2.0 minor release #3501

Closed
3 tasks
wolfgangwalther opened this issue May 9, 2024 · 8 comments · Fixed by #3552
Closed
3 tasks

Write docs for v12.2.0 minor release #3501

wolfgangwalther opened this issue May 9, 2024 · 8 comments · Fixed by #3552
Assignees
Labels
docs Only related to documentation

Comments

@wolfgangwalther
Copy link
Member

This is already listed in #3113 (comment), but to give this more visibility I'll create an issue about it.

Ever since merging the postgrest-docs repo into the core repo, we are supposed to merge docs together in the same PR as the corresponding feature. This didn't always happen initially, but we are getting better at it. However, we still have some unreleased feature commits on the main branch, which happened before the docs merge and thus have no corresponding docs written, yet.

This is blocking the next minor release, so needs to be taken care of.

I went through the changelog on main again, and I think the following still need to be documented:

@steve-chavez since you merged the first two and wrote the last yourself - can you take care of the docs for those to unblock a release?

There is also #3061, which is still undocumented, but also blocking a new minor release is #3242 which will be fixed in #3358. This essentially contains the docs for #3061, too.

@laurenceisla
Copy link
Member

laurenceisla commented May 22, 2024

I think this is already documented? I can see the deprecation notices in:

@laurenceisla
Copy link
Member

I think this is already documented? I can see the deprecation notices in:

Ah, the link from the changelog is not working anymore though. Fixing in #3552

@steve-chavez
Copy link
Member

I think we can do a new minor release now. @wolfgangwalther Should just doing postgrest-release be enough?

I just executed it and got:

Current version is 12.1
Updating postgrest.cabal ...
Updating CHANGELOG.md ...
Committing ...
Current version is 12.2.0
Updating postgrest.cabal ...
Committing (devel bump)...
Remote not found. Please push manually ...

I wonder why it didn't find the remote, I have:

git remote -v | grep PostgREST/postgrest
upstream        git@github.com:PostgREST/postgrest (fetch)
upstream        git@github.com:PostgREST/postgrest (push)

@laurenceisla
Copy link
Member

Also, I think the next minor should be 12.1.0, since the latest release was 12.0.3 . Unless I'm missing something, postgrest-release should use the current version in postgrest.cabal for a minor release.

@wolfgangwalther
Copy link
Member Author

Also, I think the next minor should be 12.1.0, since the latest release was 12.0.3 . Unless I'm missing something, postgrest-release should use the current version in postgrest.cabal for a minor release.

No, we agreed that uneven minor releases are the on-going development version.

So the current development version is 12.1. We are going to release 12.2 - and at the same time we switch the main branch to the new development version 12.3. That's all hardcoded in the postgrest-release tool already.

@wolfgangwalther
Copy link
Member Author

I think we can do a new minor release now. @wolfgangwalther Should just doing postgrest-release be enough?

I still want to check this TODO here:

Add "pg version last supported by pgrst version X" and maybe "support for pg version Y will be removed in next version of pgrst" hints on startup as discussed in #2052 (comment).

So yeah, now it's on me.


I wonder why it didn't find the remote, I have:

Ah my remotes end in .git and I assume this would always be the case:

upstream	git@github.com:PostgREST/postgrest.git (fetch)
upstream	git@github.com:PostgREST/postgrest.git (push)

I will change the script accordingly.

@laurenceisla
Copy link
Member

No, we agreed that uneven minor releases are the on-going development version.

Ah, got it, it seems that I missed that.

@wolfgangwalther
Copy link
Member Author

To be precise:

  • 12.1 is the development version (uneven minor, no patch)
  • 12.2.0 is the proper release (even minor, including patch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Only related to documentation
Development

Successfully merging a pull request may close this issue.

3 participants