Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New csproj #37

Open
DaniilSokolyuk opened this issue Jan 9, 2018 · 4 comments
Open

New csproj #37

DaniilSokolyuk opened this issue Jan 9, 2018 · 4 comments

Comments

@DaniilSokolyuk
Copy link
Contributor

DaniilSokolyuk commented Jan 9, 2018

Hi!
We are migrated our projects to new csproj format (like this https://github.com/MiniProfiler/dotnet/blob/master/samples/Samples.Mvc5/Samples.Mvc5.csproj https://github.com/NickCraver/StackExchange.Exceptional/blob/master/samples/Samples.MVC5/Samples.MVC5.csproj) but the compilation does not work anymore

Thousands errors like this

C:\Work\....cs(104,22): error CS0246: The type or namespace name 'xxx' could not be found (are you missing a using directive or an assembly reference?)
@m0sa
Copy link
Contributor

m0sa commented Jan 9, 2018

Can you please provide more details on how exactly you're building the project / solution, and what types are missing?

Note that the test projects in the master branch is also using <PackageReference>. I did not attempt to make the build work with dotnet build / dotnet msbuild, though.

@m0sa
Copy link
Contributor

m0sa commented Jan 10, 2018

Also the examples above are not supported by the tooling, see - dotnet/project-system#2670

@DaniilSokolyuk
Copy link
Contributor Author

Not supported, but works :)

@DaniilSokolyuk
Copy link
Contributor Author

DaniilSokolyuk commented Jan 11, 2018

@m0sa
Sorry, i found problem
Some *.cs files were encoded in 'windows-1251', i resave all files in utf8 and everything is working now

but dotnet build, and vs studio build can build with any encoding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants