Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(rich-text) Extra line inserted when advancing past code block to following HR element #199

Open
yellis opened this issue Jul 17, 2022 · 1 comment
Labels
bug Something isn't working mode - rich text Affects the editor's rich text (wysiwyg) mode

Comments

@yellis
Copy link
Contributor

yellis commented Jul 17, 2022

Describe the bug
In rich text mode, having an horizontal rule after a source fence, if you move the cursor down ↓ it visually pushes the


down one line each time you go over it.

There is also no way to get beneath the HR element when it is the last element in the doc.

To Reproduce

  1. MD mode, enter this text:
```
text in fence
```
---
  1. Switch to RT mode. Click in text, then down arrow
  2. Observe, a new line is inserted
    image

Root cause is not that you cant get past the HR in RT mode, since when there is more text beneath it, the link still appears.

Expected behavior
Should be able to move beyond the HR to go past it, the way that can be done when it is preceded by regular text and not a fenced code block

Desktop (please complete the following information):
Windows 11 Chrome 103

Additional context
https://meta.stackexchange.com/a/380438/51

@yellis yellis added bug Something isn't working mode - rich text Affects the editor's rich text (wysiwyg) mode labels Jul 17, 2022
@yellis yellis changed the title bug(richtext) bug(richtext) Extra line inserted when advancing past code block to following HR element Jul 17, 2022
@yellis yellis changed the title bug(richtext) Extra line inserted when advancing past code block to following HR element bug(rich-text) Extra line inserted when advancing past code block to following HR element Jul 17, 2022
@KyleMit
Copy link
Collaborator

KyleMit commented Aug 18, 2022

Can also repro with just an empty block, not just restricted to hr as the next element.

Here's me just hitting up-arrow / down-arrow in and out of a code block

arrow-down-new-line
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mode - rich text Affects the editor's rich text (wysiwyg) mode
Projects
Status: Todo
Development

No branches or pull requests

2 participants