Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a post is both "watched" and "deleted", the background color styling for deleted should take precendence #957

Open
johnmwright opened this issue May 27, 2022 · 2 comments
Labels
bug A reproducible problem with the Stacks code

Comments

@johnmwright
Copy link

When a post is both "watched" and "deleted", the watched styling takes precedence instead of the deleted styling. In my opinion, it should be the other way around (the fact it's deleted is more important than the fact it's watched).

Specifically, a post that has .s-post-summary__deleted and .s-post-summary__watched will have it's background color set to the watched value.

Here is a screenshot showing four posts:

  • a deleted post with red background
  • a watched & delete post with the yellow background (this is the one I think should be red)
  • a watched post with yellow background
  • a normal post with neither watched or deleted

image

Note that the style appears to come from primary.css instead of stacks.css:

image

@dancormier dancormier added the bug A reproducible problem with the Stacks code label May 27, 2022
@dancormier
Copy link
Contributor

Seems the issue is an additional post summary style in _base-primary.less.

// TODO upstream?
.s-post-summary__watched {
    .tagged-interesting;
}

@ondrejkonec
Copy link

Hi there!

I take a look and tried to fix this bug in post-primary.less file in Stacks here #1134

Because the component structure does does not have strict methodology, I chose a way to just raise the priority of the selector a bit.

What do you think @dancormier ?

Hope it helps!

Ondřej

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A reproducible problem with the Stacks code
Projects
None yet
Development

No branches or pull requests

3 participants