GCLOUD: split horizon domains within the same GCP project

[asn-iac]

Is your feature request related to a problem? Please describe.
Google Cloud DNS API supports "Private" dns zones, and can have multiple dns zones with the same dns name in the same project, enabling split horizon dns (https://cloud.google.com/dns/docs/zones/zones-overview#split-horizon). #2482 adds support for private dns zones, however the dnscontrol GCLOUD provider still cannot support split horizon dns within the same GCP project.

Describe the solution you'd like
Support split horizon domains within the same GCP project

Describe alternatives you've considered
Private and Public zones can be defined in different GCP projects to enable split horizon dns.

Additional context
In order to fully support split horizon domains within the same GCP project, need to parse the zone Visibility field from *ManagedZone in *gcloudProvider.loadZoneInfo(), but currently gcloudProvider.zones is map[string]*gdns.ManagedZone where the map keys are the zone dns names. A given GCP project can have multiple zones of the same dns name.

[tlimoncelli]

CC @riyadhalnur (maintainer of the Google DNS provider)

[tlimoncelli]

This should be fixed as of #2481. If not, please re-open this issue. Thanks!

[riyadhalnur]

Hey @tlimoncelli, I asked @asn-iac to open this as an actionable ticket for the TODO from the original support in #2481. We can re-open in case someone's interested in picking this up

[asn-iac]

for additional context, #2481 only added support for private domains. the provider would still need to be refactored to support split-horizon domains in the same gcloud project as it currently relies on the zone dns name.

dnscontrol/providers/gcloud/gcloudProvider.go

Lines 146 to 150 in d4f6e01

	// TODO(asn-iac): In order to fully support split horizon domains within the same GCP project,
	// need to parse the zone Visibility field from *ManagedZone, but currently
	// gcloudProvider.zones is map[string]*gdns.ManagedZone
	// where the map keys are the zone dns names. A given GCP project can have
	// multiple zones of the same dns name.

we haven't had a direct need for this yet but if we decide to spend cycles on it I'll pick this up and re-open.

[tlimoncelli]

Sounds good! I've re-opened the issue!