NSONE: Value None for field '<obj>.tags' is not of type object

[norman-zon]

Describe the bug

Since updating from 4.4.1 to 4.6.0 I cannot push changes to NS1 anymore.

For any record type I get:

FAILURE! PUT https://api.nsone.net/v1/zones/<zone>/<record>/<type>: 400 Input validation failed (Value None for field '<obj>.tags' is not of type object)

I see there already is a workaround for a similiar problem in the provider.

To Reproduce
Steps to reproduce the behavior:

1. Push any change to NS1

Expected behavior
The record gets created/updated without issues

DNS Provider

• NS1

[norman-zon]

Ping @costasd

[costasd]

hm. will look very soon, thanks.

[costasd]

Confirmed. Seems that the latest version (2.7.13) - and the version before that (2.7.12) is not working correctly with NS1. Will follow up with upstream.

In the meantime, #2642 should create a working setup again.

@tlimoncelli wondering if you have any ideas how we can protect ourselves from such stuff in the future. Even upgrading minor versions can be brittle, so we need to ensure that any module updates run the integration suite for ns1.

[tlimoncelli]

@tlimoncelli wondering if you have any ideas how we can protect ourselves from such stuff in the future. Even upgrading minor versions can be brittle, so we need to ensure that any module updates run the integration suite for ns1.

On one hand, SemVer was supposed to fix this kind of problem. In reality is just makes this kind of problem rare. SemVer isn't an exact science. We should complain to the upstream; they should either revert the brokenness or increment the major version number.

The other way to prevent this in the future is more testing. The GHA workflow doesn't have creds for NS1, therefore the automated tests are skipped. In general I only upgrade the dependencies of providers that have opt-ed in to automated testing. It is the responsibility of provider maintainers to upgrade their own dependencies. Looking at the git log, I violated that rule in 2be618a. Either I misread it or figured "gosh, it's a minor revision... what could go wrong?"

I'll try to do a new release in the next week. (4.6.x)

If you'd like to set up automated testing, I'd need you to create a test (free) account on NS1 and send me ("donate") the credentials. Contact me offline for instructions (tlimoncelli at stackoverflow dot com). Some details here: https://docs.dnscontrol.org/developer-info/byo-secrets (I should update that soon, it is incomplete).

[costasd]

ah excellent, I think I did all of these in the past, outside of sharing the secrets with you 💥. Will go over it again just in case something changed in the config since then and then share the secrets.

[tlimoncelli]

If you would like to set up a test account with NS1, I'll add the creds to the CI/CD pipeline so that NS1 gets tested with every PR. You can use https://transfer.secretoverflow.com/u/tlimoncelli to securely send me credentials.

[costasd]

Upstream bug report ns1/ns1-go#224