Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALIAS support for INWX provider #2742

Open
ngrie opened this issue Dec 25, 2023 · 1 comment
Open

Add ALIAS support for INWX provider #2742

ngrie opened this issue Dec 25, 2023 · 1 comment

Comments

@ngrie
Copy link

ngrie commented Dec 25, 2023

Is your feature request related to a problem? Please describe.
While migrating my DNS zones to INWX, I noticed that there is no ALIAS support for that provider in DNSControl:

printIR.go:113: ERROR: domain xxxx.com uses ALIAS records, but DNS provider type INWX does not support them

INWX however does support ALIAS records using the web interface and the API.

Additional context
From briefly scanning the code, I would guess that updating this line:

providers.CanUseAlias: providers.Cannot("INWX does not support the ALIAS or ANAME record type."),

as well as this part:

/*
INWX is a little bit special for CNAME,NS,MX and SRV records:
The API will not accept any target with a final dot but will
instead always add this final dot internally.
Records with empty targets (i.e. records with target ".")
are not allowed.
*/
case "CNAME", "NS":
req.Content = content[:len(content)-1]

could be enough to add support? (I am not used to do Go programming so ...)

@cafferata
Copy link
Collaborator

Ping @patschi, the maintainer of this provider.

egon0 added a commit to egon0/dnscontrol that referenced this issue Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants