Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependabot PRs failing #2778

Open
tlimoncelli opened this issue Jan 8, 2024 · 0 comments
Open

Dependabot PRs failing #2778

tlimoncelli opened this issue Jan 8, 2024 · 0 comments
Labels
dependencies Pull requests that update a dependency file Type: Maintenance

Comments

@tlimoncelli
Copy link
Contributor

I have a hunch that failures like

https://github.com/StackExchange/dnscontrol/actions/runs/7450408350/job/20269530961

will not happen if we make the *_DOMAIN variables secrets instead of env variables.

I'm opening this issue because that URL was in my paste buffer and I didn't want to lose it. Will investigate more later.
@cafferata cafferata added Type: Maintenance dependencies Pull requests that update a dependency file labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cafferata @tlimoncelli