Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send vs transfer #83

Open
rstormsf opened this issue Nov 13, 2017 · 0 comments
Open

send vs transfer #83

rstormsf opened this issue Nov 13, 2017 · 0 comments

Comments

@rstormsf
Copy link
Contributor

rstormsf commented Nov 13, 2017 •
edited

https://github.com/TokenMarketNet/ico/blob/9f114b1cad7312f95e937cd1e855af35b9d97214/contracts/CrowdsaleBase.sol#L213

https://github.com/TokenMarketNet/ico/blob/9f114b1cad7312f95e937cd1e855af35b9d97214/contracts/CrowdsaleBase.sol#L332
ethereum/solidity#610

since transfer already does throw an error on failure, I think it could be cleaner approach instead.

Proposed change to

multisigWallet.transfer(weiAmount)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rstormsf