Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Violation of interface PricingStrategy #86

Open
rstormsf opened this issue Nov 17, 2017 · 0 comments
Open

Violation of interface PricingStrategy #86

rstormsf opened this issue Nov 17, 2017 · 0 comments

Comments

@rstormsf
Copy link
Contributor

https://github.com/TokenMarketNet/ico/blob/master/contracts/PricingStrategy.sol

the contract is being used as an interface.
In Solidity, there is keyword: interface which must be used instead of contract
Also, it shouldn't have any state variables and any implementations of any methods.

Probably more accurate comment would be either:
using interface or abstract contract

Abstract contract can't also have any implementations.
So in your case it's not either an interface nor contract.

So please choose how you want it to behave.

https://solidity.readthedocs.io/en/develop/contracts.html#abstract-contracts

Interfaces
Interfaces are similar to abstract contracts, but they cannot have any functions implemented. There are further restrictions:

Cannot inherit other contracts or interfaces.
Cannot define constructor.
Cannot define variables.
Cannot define structs.
Cannot define enums.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant