Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent protocols naming in status endpoint and aeternity.yaml #4137

Open
davidyuk opened this issue May 21, 2023 · 3 comments
Open

Consistent protocols naming in status endpoint and aeternity.yaml #4137

davidyuk opened this issue May 21, 2023 · 3 comments
Labels
need/triage New issues which need to be categorized

Comments

@davidyuk
Copy link
Member

protocols in the status endpoint called hard_forks in aeternity.yaml. Naming it the same would make it more developer-friendly 馃檪
@davidyuk davidyuk added the need/triage New issues which need to be categorized label May 21, 2023
@dincho
Copy link
Member

dincho commented Nov 24, 2023

I think it have slightly different purpose, hard_forks also configure how the node switches protocol based on voting etc. while protocols only shows what protocol kicks in at what height

@davidyuk
Copy link
Member Author

Accordingly "protocol" field configures how aepps switches protocol.
In a specific setup, these values are always the same, don't they? Except for "1": 0 at the beginning of hard_forks #4203

@dincho
Copy link
Member

dincho commented Nov 30, 2023

Sorry I was confused by fork_management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage New issues which need to be categorized
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dincho @davidyuk