Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in fiat_converstion_url parameter #4335

Closed
davidyuk opened this issue Apr 21, 2024 · 1 comment · Fixed by #4338
Closed

Typo in fiat_converstion_url parameter #4335

davidyuk opened this issue Apr 21, 2024 · 1 comment · Fixed by #4338
Labels
need/triage New issues which need to be categorized

Comments

@davidyuk
Copy link
Member

aeternity/apps/aeutils/priv/aeternity_config_schema.json

Lines 1647 to 1650 in 69569d2

"fiat_converstion_url" : {
"description" : "URL of the fiat conversion.",
"type" : "string"
}

aeternity/apps/aehttp/priv/oas3.yaml

Line 2732 in 69569d2

fiat_converstion_url:

As I understand it should be fiat_conversion_url, I would sent a PR, but is it a breaking change now?
@davidyuk davidyuk added the need/triage New issues which need to be categorized label Apr 21, 2024
@dincho
Copy link
Member

dincho commented Apr 22, 2024

Let's do that before 7.0.0

@davidyuk davidyuk mentioned this issue Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage New issues which need to be categorized
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in fiat_conversion_url davidyuk/aeternity
2 participants
@dincho @davidyuk