Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not mutating global variables #1216

Open
Jack-Works opened this issue Mar 2, 2022 · 0 comments · May be fixed by #1217
Open

Do not mutating global variables #1216

Jack-Works opened this issue Mar 2, 2022 · 0 comments · May be fixed by #1217

Comments

@Jack-Works
Copy link

image

https://github.com/amark/gun/blob/5df08f91cb2959deb36c0f4f85c0e537ad103e0c/src/shim.js

The following are not in the JS standard:

  • String.random
  • String.match
  • String.hash
  • Object.plain
  • Object.empty
  • setTimeout.turn
  • setTimeout.poll
  • setTimeout.each

Please do not try to modify those objects but use them as internal utils, thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove built-in pollution Jack-Works/gun
1 participant
@Jack-Works