Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][move-compiler-v2] compiler-v2 fails vm_test_harness/example.move test #13255

Open
brmataptos opened this issue May 11, 2024 · 2 comments
Open
Assignees
Labels
bug Something isn't working compiler-v2-stable compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@brmataptos
Copy link
Contributor

See

third_party/move/testing-infra/transactional-test-runner/tests/vm_test_harness/example.v2_exp

in #13216 .

There might be some problem with the test harness, but task 4 of the test case fails compilation with MOVE_COMPILER_V2=true.

@brmataptos brmataptos added bug Something isn't working compiler-v2 labels May 11, 2024
@sausagee sausagee added the stale-exempt Prevents issues from being automatically marked and closed as stale label May 20, 2024
@brmataptos
Copy link
Contributor Author

This is related to #13392. Namely, the problem is that the transactional tests just simulate publishing code, but don't really publish it anywhere. This means we have to treat the previous code as a "to be compiled" source, but if there is a conflict with the later source we have a problem.

@rahxephon89
Copy link
Contributor

@wrwg @brmataptos, this error happens because when running expansion phase in V2, all modules lib_definitions are moved to source_definitions. If a module in lib_definitions has the same address and same name as an existing module in source_definitions, the error Duplicate definition for module will be raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler-v2-stable compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Status: 🏗 In progress
Development

No branches or pull requests

4 participants