Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider consistent naming for subgraph configuration #295

Open
andy-hook opened this issue Sep 18, 2020 · 1 comment
Open

Consider consistent naming for subgraph configuration #295

andy-hook opened this issue Sep 18, 2020 · 1 comment

Comments

@andy-hook
Copy link

andy-hook commented Sep 18, 2020 •
edited

I think it would be nice if the connector configuration for the provider matched those expected by the hooks. For example, I recently fat fingered the org subgraph config as it expected orgSubgraphUrl while the hooks expect subgraphUrl.

A small detail, and one easily caught in a statically typed project, but just my 2c :)
@bpierre
Copy link
Contributor

bpierre commented Sep 18, 2020

Agreed, not only for React but for the main library too: we should use subgraphUrl.

@andy-hook andy-hook changed the title React: Consider consistent naming for subgraph configuration Consider consistent naming for subgraph configuration Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpierre @andy-hook