Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylish support #17

Closed
maxigaz opened this issue Nov 26, 2016 · 11 comments
Closed

Stylish support #17

maxigaz opened this issue Nov 26, 2016 · 11 comments

Comments

@maxigaz
Copy link

maxigaz commented Nov 26, 2016

With the Firefox extensions Stylish and It's all text!, I can edit user styles with an external editor. I.e. if both are installed, when editing a style, an additional button appears on top with the label "Open in external editor".

However, there's no such button when It's all text! is replaced by withExEditor. (Edit: I'm using Firefox 50.0 under Manjaro Linux.) Therefore, I'm wondering if it's possible to implement this feature in this extension as well.

@asamuzaK
Copy link
Owner

asamuzaK commented Nov 28, 2016

I'm porting withExEditor to WebExtensions.
And in WebExtensions, content scripts only runs in "http", "https", "file", "ftp", "app" schemes.
Match patterns - Mozilla | MDN
I don't know Mozilla will implement "about" scheme in the future.
If they do, then I'll try to support Stylish.

@asamuzaK
Copy link
Owner

Note:
Bugs that seem to be related to this issue.

1269456 – Add permission to allow extensions to load semi-privileged URLs

1280370 – contextMenus do not support other protocols (ex. 'magnet:', 'acestream:', 'sop:*')

@asamuzaK
Copy link
Owner

@asamuzaK
Copy link
Owner

asamuzaK commented Jan 4, 2017

Note:
Add another bug that also seem to be related.
1271354 – Support moz-extension: urls in MatchPattern

@asamuzaK
Copy link
Owner

asamuzaK commented Jan 4, 2017

unnamed.png

Looking at this screenshot, edit page is provided by "chrome-extension" scheme, so if the bug mentioned above (1271354 – Support moz-extension: urls in MatchPattern) is resolved, it seems that withExEditor can be applied.
Plus Stylish need to be updated to WebExtensions.

@asamuzaK
Copy link
Owner

1271354 - Support moz-extension: urls in MatchPattern is marked as FIXED, but it is limited to it's own moz-extension: url, which means withExEditor can't be enabled in other extension's moz-extension: url.

Anyway, Stylish does not seem to be switched to WebExtensions?

@maxigaz
Copy link
Author

maxigaz commented Sep 14, 2017

Anyway, Stylish does not seem to be switched to WebExtensions?

You're right, although I personally use Stylus now.

@asamuzaK
Copy link
Owner

Should I close this then?

@maxigaz
Copy link
Author

maxigaz commented Sep 14, 2017

It is fine by me, but I would be more interested in seeing it compatible with Stylus, which is already a WebExtension. Shall I create a separate issue for that?

@asamuzaK
Copy link
Owner

As mentioned above, you can not execute withExEditor on Stylus' edit page (it's moz-extension://).

It is possible to interact messages between addons using runtime.connect() or runtime.sendMessage(), though.
However, in this case, both add-ons need to correspond, so it may not be so easy.

Would you contact the author of Stylus and see if he/she is interested to correspond with withExEditor?

@asamuzaK
Copy link
Owner

I will close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants