-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests of TestCLITimestampParser failing, maybe due to DST #8644
Comments
Can confirm AUR package
|
Fellow arch user here, I ran into a similar error and noticed some of my own config on the failure error messages. I tried un-setting the |
@j3m7 thank you for investigating - neither of those are set in my environment. |
Thanks for reporting this issue. I brought this up for discussion with the team, and the consensus is that more investigation is required into these tests. The tests were written a long time ago and likely need to be rewritten. If anyone has any other details to share, please feel free to add those here. |
As a workaround temporary setting timezone to one without DST helps (e.g. Asia/Baghdad) |
def test_iso(self):
E AssertionError: '1970-01-01T01:00:00+00:00' != '1970-01-01T00:00:00+00:00' linux duer module. |
Describe the bug
Currently when running tests in England, two of them fail, expecting two timestamps to equal when they are in fact exactly one hour apart.
Expected Behavior
All tests should pass, xfail, or be skipped.
Current Behavior
Tests fail with the following output:
Reproduction Steps
As mentioned, the timestamps are off by one hour, and I am currently in DST (against my will), so set your timezone appropriately. For reference, the current output of
date
isMon 22 Apr 00:05:23 BST 2024
.The commands run to get here are documented in the AUR PKGBUILD for
aws-cli-v2
, important part reproduced below:It appears in a development environment, this would be reproducible with:
AWS_SECRET_ACCESS_KEY=fake_key AWS_ACCESS_KEY_ID=fake_id python -m pytest tests -n auto --dist loadfile --ignore=tests/backends --ignore=tests/integration
Possible Solution
I haven't investigated, it's late and I hit this right as I was updating my system before bed. Generally I throw freezegun at these sorts of tests so they fail all the time instead of only for six months of the year, and deal with everything in UTC as much as possible.
Additional Information/Context
No response
CLI version used
2.15.40
Environment details (OS name and version, etc.)
Arch Linux (by the way), Python 3.11.8, yay v12.3.5, pacman v6.1.0, libalpm v14.0.0.
The text was updated successfully, but these errors were encountered: