Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow dependency versioning requirements #20

Open
binaryphile opened this issue Jul 11, 2016 · 2 comments
Open

allow dependency versioning requirements #20

binaryphile opened this issue Jul 11, 2016 · 2 comments

Comments

@binaryphile
Copy link

The DEPS specification allows me to pull particular packages from github. However, I would also like to be able to specify the particular version of the desired package, since master is usually a moving target and can break the contract with my code over time.

The simplest thing would be to specify a tag like "v1.0" which would check out that tag from the repository after it had been cloned.

This would also affect the upgrade command, since this package wouldn't be updated without changing the version specified in DEPS.

I'm not requesting that multiple versions of the dependency be able to coexist under basher, although that would be another nice-to-have (i.e. different feature request). I could definitely see specifying the version number in the repo's path in anticipation of such a feature, however, such as "cellar/packages/my-user/my-package-v0.1".
@juanibiapina
Copy link
Member

I agree this is a great feature, not only for deps, but also for normal installs.

@juanibiapina juanibiapina mentioned this issue Jul 11, 2016
Closed
YarekTyshchenko added a commit to YarekTyshchenko/basher that referenced this issue Mar 27, 2017
@YarekTyshchenko
Install a specific branch or tag with @ syntax
d0131af 
Modify install command to take `package@ref` style syntax. This should
be idiomatic for everyone.

The ref selection is permanent, theres no way to switch the package
to a different ref without re-installing it.

Sort of related to basherpm#20 in terms of versioning packages
@juanibiapina
Copy link
Member

@binaryphile how do you like the work on #27 ? I haven't tested it with dependencies, but it seems like it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@binaryphile @juanibiapina