Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - dependencies should pull from most recent tag, not master #835

Closed
bitcoin-tools opened this issue May 11, 2024 · 0 comments · Fixed by #938
Closed

[BUG] - dependencies should pull from most recent tag, not master #835

bitcoin-tools opened this issue May 11, 2024 · 0 comments · Fixed by #938
Labels
bug Something isn't working

Comments

@bitcoin-tools
Copy link
Owner

bitcoin-tools commented May 11, 2024

Expected Behavior

Calling this a bug instead of a feature due to the potential security and breaking UX implications of pulling from master.

To avoid breaking nodebuilder whenever dependencies need to change, have the user run nodebuilder with the most recent version tag (which we already do) that also downloads runtime dependencies from the most recent version tag (which we don't do right now).

Same with the Dockerfiles, have them do have them pull from master.

Actual Behavior

Right now dependencies are pulled from master branch, both in the main script and in the Dockerfiles.

Steps to Reproduce

Optional Screenshots

No response

Optional Logs

No response

Operating System

No response

Operating System version

No response

@bitcoin-tools bitcoin-tools added the bug Something isn't working label May 11, 2024
@bitcoin-tools bitcoin-tools changed the title [BUG] - runtime dependencies should pull from most recent tag, not master [BUG] - dependencies should pull from most recent tag, not master May 19, 2024
@bitcoin-tools bitcoin-tools linked a pull request May 20, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant