Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 5 Figure 5-10 Correction #1024

Open
traffictse opened this issue Sep 17, 2022 · 1 comment
Open

Chapter 5 Figure 5-10 Correction #1024

traffictse opened this issue Sep 17, 2022 · 1 comment

Comments

@traffictse
Copy link

The current Figure 5-10 titled "Extending a parent public key to create a child public key" is quoted as:

image

This previous figure (not the current one) intended to show the two ways to derive a child public key: 1) from the child private key derived from the parent private key by CKDprv; 2) directly from the parent public key by CKDpub. And the current one plans to show the way 2) only.

However, in the previous figure, it was inappropriate that an arrow was drawn from Parent Private Key directly to Child Private Key without HMAC-SHA512 involved in the middle.

Also, in the current figure, it is inappropriate that an arrow is drawn from Parent Public Key directly to Child Public Key bypassing the middle HMAC-SHA512, which seems impossible. The arrow from Child Public Key to Child Chain Code also does not exist.

The following is for reference only to show both ways of the deviation of a child public key.

fig 5-11

@RequestPrivacy
Copy link

However, in the previous figure, it was inappropriate that an arrow was drawn from Parent Private Key directly to Child Private Key without HMAC-SHA512 involved in the middle.

Also, in the current figure, it is inappropriate that an arrow is drawn from Parent Public Key directly to Child Public Key bypassing the middle HMAC-SHA512, which seems impossible.

See my explanation of the "bypassing" of HMAC-SHA512 by the parent public/private key in your issue #1023. The same applies here.

The arrow from Child Public Key to Child Chain Code also does not exist.

I think that's correct, the child chain code should be the same (the right 256 bits of the HMAC-SHA512) and don't depend on the child public key in any form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants