Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phemex: fetchFundingHistory -> amount: null #22434

Closed
egabosh opened this issue May 8, 2024 · 8 comments · Fixed by #22443
Closed

Phemex: fetchFundingHistory -> amount: null #22434

egabosh opened this issue May 8, 2024 · 8 comments · Fixed by #22443
Assignees
@ttodua @sc0Vu
Labels
bug

Comments

@egabosh
Copy link

egabosh commented May 8, 2024

Operating System

Debian 12

Programming Languages

Python

CCXT Version

4.3.18

Description

Moin,

Method fetchFundingHistory gives "amount: null" on Phemex.
Seems wrong for me.

Code

print(exchange.fetchFundingHistory('BTC/USDT:USDT'))

Example Result:

    "info": {
      "symbol": "BTCUSDT",
      "currency": "USDT",
      "execQtyRq": "0.001",
      "side": "Buy",
      "execPriceRp": "64905.93672508",
      "execValueRv": "64.90593673",
      "fundingRateRr": "0.00003809",
      "feeRateRr": "0.00003809",
      "execFeeRv": "0.00247227",
      "createTime": "1713744000000"
    },
    "symbol": "BTCUSDT",
    "code": "USDT",
    "timestamp": 1713744000000,
    "datetime": "2024-04-22T00:00:00.000Z",
    "id": null,
    "amount": null
  }

Amount should not be null I think,
@egabosh
Copy link
Author

egabosh commented May 8, 2024

I think amount should be value of "execFeeRv"

@sc0Vu sc0Vu self-assigned this May 9, 2024
@sc0Vu
Copy link
Contributor

sc0Vu commented May 9, 2024 •
edited

@egabosh I think we've added in this commit c47df4ffd86, could you upgrade and try again?

@sc0Vu sc0Vu added the question label May 9, 2024
@egabosh
Copy link
Author

egabosh commented May 9, 2024

@sc0Vu Didn't change. Amount is still null/None
did a fresh
git clone https://github.com/ccxt/ccxt.git --depth 1
Is this enough?

@egabosh
Copy link
Author

egabosh commented May 9, 2024

Don't understand the code completely but maybe it is a typo execFeeEv should be execFeeRv? Or something changed on Phemex?

@carlosmiei
Copy link
Collaborator

@egabosh I think you're right, we have an issue there. Thanks for bringing our attention to this!

@carlosmiei carlosmiei added bug and removed question labels May 9, 2024
@ttodua ttodua mentioned this issue May 9, 2024
Merged
@egabosh
Copy link
Author

egabosh commented May 9, 2024

Thanks a lot for your great and fast support!

@egabosh
Copy link
Author

egabosh commented May 15, 2024

Works now. Thank you!

@carlosmiei
Copy link
Collaborator

@egabosh No problem, let us know if anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttodua ttodua

@sc0Vu sc0Vu

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(phemex) - funding fees ttodua/ccxt
4 participants
@ttodua @sc0Vu @carlosmiei @egabosh