-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix - a task will run multiple times when chaining chains with groups #9021
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9021 +/- ##
==========================================
- Coverage 77.80% 77.78% -0.03%
==========================================
Files 150 150
Lines 18680 18680
Branches 3192 3192
==========================================
- Hits 14534 14530 -4
- Misses 3854 3856 +2
- Partials 292 294 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the approach seems reasonable, but I will wait for thorough review from Nusnus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this indeed fixes the test I proposed in #9013 🎉
Co-authored-by: Nils Caspar <ncaspar@me.com>
Fixes #9020
On
_chain.__or__
there is already a logic that knows to take a group/chord, and check if it needs an upgrade to chord. The problem is that if we chain 2 chains, it skips this logic and just constructs a chain from all the tasks, without any checks for an upgrade. Therefore, in a case where the first chain ends with a group, it will not create a chord.