Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom wallet not loading walletconnect QR code on desktop #287

Open
1 task done
obernardovieira opened this issue Jul 6, 2022 · 2 comments
Open
1 task done

Custom wallet not loading walletconnect QR code on desktop #287

obernardovieira opened this issue Jul 6, 2022 · 2 comments
Assignees
Labels
Applications bug Something isn't working

Comments

@obernardovieira
Copy link

obernardovieira commented Jul 6, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Description

We've added an additional wallet. It's being listed and works well on mobile. But should also work well on desktop (we tried using walletconnect and works) but instead gives a message "doesn't seem to support deeplinking, but you can still copy the wallet-connect URI to connect."

Steps to reproduce

  1. Using an example code, copy/paste this config https://github.com/impactMarket/app/blob/main/src/components/WrapperProvider.tsx#L86
  2. Try to login with that wallet on desktop, should show a RQ code

Expected behavior

Should show a QR code on desktop (not working) and openning wallet on mobile (working well)

Screenshot

image

Where is the problem happening?

Desktop

Environment

Device: [macOS]
OS: [12.4]
Browser: [Brave]
Version: [1.40.107]

What version of react-celo were you using? (This can be found in the list of wallets in the "Connect" modal)

4.0.1

What wallet were you using?

custom (BitKeep in this case)

What is the dApp URL? (if applicable)

No response

Additional context

No response

@obernardovieira obernardovieira added the bug Something isn't working label Jul 6, 2022
@aaronmgdr aaronmgdr self-assigned this Jul 11, 2022
@obernardovieira
Copy link
Author

This has been solved on 4.1.0, but since then, it shows the QR (solving this issue), but the connection always ends in timeout without connecting

@obernardovieira
Copy link
Author

nevermind, works well, but doesn't work in dev mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants