Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PMD 7.1.0 Violations #14870

Open
mahfouz72 opened this issue May 9, 2024 · 1 comment
Open

Fix PMD 7.1.0 Violations #14870

mahfouz72 opened this issue May 9, 2024 · 1 comment
Labels

Comments

@mahfouz72
Copy link
Member

mahfouz72 commented May 9, 2024

After migrating To PMD 7.1.0, it caught new violations in our Codebase (#14856 (comment)). We should investigate this list and fix all violations if they are valid. if a violation is a false positive it should be reported to PMD

the suppressions were added in 5a1f41e
List of violations: https://gist.github.com/mahfouz72/d199fca33ce2c9e8d84be3882403093c

we should split down the list to make the fix easier so a few PRs are fine


Investigate #14870 (comment) about package private scope of visibility

@romani
Copy link
Member

romani commented May 9, 2024

Please inline violations in text format, not xml. It much easier to read for humans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants