-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fly execute does not exclude MacOS extended file attributes #8916
Labels
Comments
Another thing we could do is just inline the code used from https://github.com/vmware-archive/go-archive and make the fix there. I'd also be happy to PR that, but I'd like to get a go-ahead first. |
@selzoc I'd be happy with a PR bringing in the |
selzoc
added a commit
to selzoc/concourse
that referenced
this issue
Apr 5, 2024
This is in preparation for making a modification to it in relation to concourse#8916. The original repo has been archived for several years.
selzoc
added a commit
to selzoc/concourse
that referenced
this issue
Apr 5, 2024
On recent MacOS machines, tar files created (i.e. from `fly execute` with a local resource) include files prefixed by `._`. As a result, once you transfer this tar file to a Linux system and untar, these files may interfere with jobs. This flag will prevent that from happening. Fixes concourse#8916 See cloudfoundry/bosh-utils@f79167b for a similar fix to the `bosh` cli.
selzoc
added a commit
to selzoc/concourse
that referenced
this issue
Apr 5, 2024
This is in preparation for making a modification to it in relation to concourse#8916. The original repo has been archived for several years. Signed-off-by: Chris Selzo <chris.selzo@broadcom.com>
selzoc
added a commit
to selzoc/concourse
that referenced
this issue
Apr 5, 2024
On recent MacOS machines, tar files created (i.e. from `fly execute` with a local resource) include files prefixed by `._`. As a result, once you transfer this tar file to a Linux system and untar, these files may interfere with jobs. This flag will prevent that from happening. Fixes concourse#8916 See cloudfoundry/bosh-utils@f79167b for a similar fix to the `bosh` cli. Signed-off-by: Chris Selzo <chris.selzo@broadcom.com>
@taylorsilva here you go: #8939. |
taylorsilva
pushed a commit
to selzoc/concourse
that referenced
this issue
Apr 28, 2024
This is in preparation for making a modification to it in relation to concourse#8916. The original repo has been archived for several years. Signed-off-by: Chris Selzo <chris.selzo@broadcom.com>
taylorsilva
pushed a commit
to selzoc/concourse
that referenced
this issue
Apr 28, 2024
On recent MacOS machines, tar files created (i.e. from `fly execute` with a local resource) include files prefixed by `._`. As a result, once you transfer this tar file to a Linux system and untar, these files may interfere with jobs. This flag will prevent that from happening. Fixes concourse#8916 See cloudfoundry/bosh-utils@f79167b for a similar fix to the `bosh` cli. Signed-off-by: Chris Selzo <chris.selzo@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
fly execute
, when run from a recent MacOS machine, does not pass the--no-mac-metadata
flag to thetar
command. This results in the upload of many files prepended by._
that represent extended file attributes, which causes issues with builds. For example, if you are running git operations, suddenly you have many untracked files that were not apparent on your local computer.From the bsdtar man page:
Steps to reproduce
Clone this repository to
$HOME/workspace/concourse
, verify that your MacOS machine uses these extended attributes with:Then, using this task.yml:
run
Expected results
Actual results
(note that every file has a "double" prepended with
._
)Additional context
I made a similar fix to the bosh cli, and that change made locally to
fly
results in the expected output.However, I saw that the library that
fly
uses, https://github.com/vmware-archive/go-archive, has been archived for ~2 years (and the last commit was 5 years ago). The library that it was forked from, https://github.com/cloudfoundry/archiver, seems to be maintained, but the interface is different, so it wouldn't be a drop-in replacement.I am happy to make a PR to https://github.com/vmware-archive/go-archive, but that would necessitate that it be unarchived and eventually bumped in this repo.
What do y'all think would be a good path forward?
Triaging info
7.11.0
The text was updated successfully, but these errors were encountered: