-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline task configs are not validated when setting a pipeline #8923
Comments
In the logs, I see some of these:
|
might be related to #8676 |
also related to #7546 |
I think this is a pipeline config issue... I modified the pipeline a bit to run on my concourse: ---
resources:
- name: puczatbot_source
type: git
source:
uri: https://github.com/concourse/concourse.git
branch: master
- name: puczatbot_image
type: registry-image
icon: docker
source:
repository: concourse/concourse
- name: golang-1.18-image
type: registry-image
icon: docker
source:
repository: golang
tag: 1.18
jobs:
- name: build-and-push
plan:
- get: puczatbot_source
trigger: true
- get: golang-1.18-image
trigger: true
- task: debug-step
config:
platform: linux
image_resource:
type: registry-image
source: {repository: alpine}
inputs:
- name: puczatbot_source
run:
path: /bin/sh
args:
- -cx
- |
ls -al
export
pwd
- task: build-puczatbot
image: golang-1.18-image
config:
platform: linux
inputs:
- name: puczatbot_source
ouputs:
- name: puczatbot-artifacts
run:
path: /bin/sh
args:
- -cx
- |
cd puczatbot_source
ls -al
pwd
ls -al
cp README.md ../puczatbot-artifacts/
- task: debug-step2
config:
platform: linux
image_resource:
type: registry-image
source: {repository: alpine}
inputs:
- name: puczatbot-artifacts
run:
path: /bin/sh
args:
- -cx
- |
ls -al
export
pwd
- task: build-docker-image
privileged: true # oci-build-task must run in a privileged container
config:
platform: linux
image_resource:
type: registry-image
source:
repository: concourse/oci-build-task
inputs:
- name: puczatbot_source
- name: puczatbot-artifacts
outputs:
- name: image
params:
CONTEXT: puczatbot_source/
run:
path: build
- put: puczatbot_image
params:
image: image/image.tar Initially while modifying the pipeline to get it running, I noticed that the output dir
This task doesn't fail because the - cp puczatbot ../puczatbot-artifacts
+ cp puczatbot ../puczatbot-artifacts/ So at this point I'm like "okay, there's gotta be a typo or something here" and sure enough: - task: build-puczatbot
image: golang-1.18-image
config:
platform: linux
inputs:
- name: puczatbot_source
- ouputs:
+ outputs:
- name: puczatbot-artifacts
run:
path: /bin/sh You dropped a "t" 🙃 I guess inline task configs aren't checked though :( If I run that one task as a one-off using platform: linux
image_resource:
type: registry-image
source:
repository: busybox
inputs:
- name: puczatbot_source
ouputs:
- name: puczatbot-artifacts
run:
path: /bin/sh
args:
- -cx
- |
cd puczatbot_source
ls -al
pwd
ls -al
cp README.md ../puczatbot-artifacts/ Result:
AHH! The expected error! So the real issue here is that inline task configs are not checked by the pipeline validator. |
Summary
I'm trying to pass an output of a task into an input of another task, and it's does not seem to be working
Steps to reproduce
Given and ran this pipeline manifest:
In step build-puczatbot I'm trying to create an output named puczatbot-artifacts and then use it in steps debug-step2 and build-docker-image. I'm getting
missing inputs: puczatbot-artifacts
Expected results
I'd expect output of a task to be possible to be passed as input of another task
Actual results
missing inputs: puczatbot-artifacts
Additional context
Running on kubernetes 1.29 with containerd runtime 1.7
Triaging info
The text was updated successfully, but these errors were encountered: