Replies: 2 comments
-
Seems reasonable for Windows. We already do it for the winbuild build method Lines 73 to 79 in de7b3e8 |
Beta Was this translation helpful? Give feedback.
0 replies
-
I'm totally fine with doing this. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
IDN support is currently disabled by default for Windows builds with both CMake and autotools.
The reason for this is Windows XP not supporting the IDN library out of the box. It requires a Microsoft package to be installed manually. Microsoft pulled this package from the internet years ago, so finding / installing it isn't trivial. XP is the oldest version we support since 960d601 #12225 (2023-10-28).
Would it be time to change these build options to enable IDN and thus potentially break the binary on Windows XP systems by default? It would remain possible to target XP by disabling the build option manually.
FWIW curl-for-win is already building with IDN support. Microsoft enables it too in their builds. vcpkg has it as an option, but perhaps not enabled by default, based on (mis?)reading the package definition.
If done, we might follow up doing the same for macOS (but that first needs more testing with AppleIDN enabled, as well as a
./configure
option for the feature.)TL;DR:
Any thoughts on these?
Beta Was this translation helpful? Give feedback.
All reactions