Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review places that create reserved in balance, and why it is not counted in reducible_balance #1484

Closed
hackfisher opened this issue Apr 24, 2024 · 5 comments
Closed

Review places that create reserved in balance, and why it is not counted in reducible_balance #1484

hackfisher opened this issue Apr 24, 2024 · 5 comments
Assignees
@boundless-forest
Labels
P-High [Priority] High

Comments

@hackfisher
Copy link
Contributor 

          https://github.com/paritytech/polkadot-sdk/blob/ffbce2a817ec2e7c8b7ce49f7ed6794584f19667/substrate/frame/balances/src/impl_fungible.rs#L47-L72
image

0xC1c8F6Ef43b39C279417E361969d535F2a20b92e

https://github.com/darwinia-network/frontier/blob/9c50b611ce93033cf2766281c8c38c73757ec502/frame/evm/src/lib.rs#L897

Originally posted by @hackfisher in #1483 (comment)
@hackfisher hackfisher added the P-High [Priority] High label Apr 28, 2024
@hackfisher
Copy link
Contributor Author

Another report from @1022ranji 0xe59261f6D4088BcD69985A3D369Ff14cC54EF1E5

image

This causes metamask show usable balance but no able to pay gas.

@hackfisher
Copy link
Contributor Author

Related:

paritytech/polkadot-sdk#1833

paritytech/polkadot-sdk#2292

@hackfisher
Copy link
Contributor Author

hackfisher commented Apr 29, 2024 •
edited

Related:

paritytech/polkadot-sdk#1833

paritytech/polkadot-sdk#2292

The substrate current using is inconsistency with the latest new definition in the referred issue.

image (5)

@hackfisher
Copy link
Contributor Author

Use polkadot-evm/frontier#1282 to fix.

This was referenced May 6, 2024
Closed
Merged
@boundless-forest
Copy link
Member

Fixed in the runtime 6630. Close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boundless-forest boundless-forest

Labels
P-High [Priority] High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hackfisher @boundless-forest