When did TypeChain refactor "commons.ts" to "common.d.ts"?

[PaulRBerg]

In commit 411805d of hardhat-packager, I added common as the name of the "excluded files" (excluded here means it is not deleted). Before that I was only excluding commons.

The question is when does Hardhat generate the common.d.ts file, and when does it generate commons.ts? Or, is it that you have switched to only generating common.d.ts?

[hasparus]

Hey @PaulRBerg.

We changed from commons.ts to common.d.ts in #472 and the change was released in @typechain/ethers-v5@7.1.1. We missed it in changesets 😓

At this moment, TypeChain generates only common.d.ts.

---

What may add to the confusion, I switched from common.d.ts to common.ts in #504 which is not released yet. However, looking at PaulRBerg/hardhat-packager@411805d it seems it won't be a problem for you.

[PaulRBerg]

Thanks for explaining! Indeed the rename to common.ts won't be a problem for the distributed package, but it will be for my tests: https://github.com/paulrberg/hardhat-packager/blob/67b426826bb486e98247392841490d6d75d79b83/test/packager.test.ts#L91.

[krzkaczor]

@PaulRBerg yes, sorry for that. I think we assumed that it's not part of the public interface. Which was a mistake...

We are going to release new major maybe today.

Paul it was great meeting you in person in Lisbon ;)

[PaulRBerg]

Don't worry, @krzkaczor! It's a minor thing.

Indeed it was great to catch up in person 🙌

[PaulRBerg]

Hey, I just upgraded to typechain@7.0.0 and @typechain/ethers-v5@9.0.0 and it looks like you have switched back to using common.ts.

Can you confirm this was intentional? Or was it an accidental reversion?

[PaulRBerg]

Hey @krzkaczor or @hasparus sorry to tag you guys but this is a real blocker.

Any chance you could take a look at my question? 🙏

[hasparus]

Hey @PaulRBerg, Forgive me, I must have missed this in GitHub notifications.

Yes, we did switch to common.ts in #504. I mentioned this in my previous comment in this discussion #526 (comment). I'm sorry for the trouble. We'll try not to touch filename this anymore.

[PaulRBerg]

No worries! Thanks for confirming. I missed the last part of your other comment.