-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROJECT ANNOUNCEMENT] Looking for maintainers for Doctest #554
Comments
Thanks @onqtam for your excellent work! |
Tagging some people who have been active with issues/PRs before with the hopes that someone would be interested:
This is not an exhaustive list and I've definitely missed people who ought to be in it! |
Unfortunately I've never been able to actually use doctest professionally. 😅 |
I know the feeling from my open source work. Thank you for all your work on this, and retain your balance! |
@onqtam : Unfortunately, I cannot spare the time to undertake this. A few months ago I undertook the maintenance and fix integration of a popular self-contained Having said that - I will try to be available to help whoever does take this mantle onto themselves. So feel free to ask me for more specific things when/if relevant. |
@eyalroz Absolutely understandable!
I might have understated the amount of work a bit indeed : ))) |
@Trass3r Thanks a lot! I sent you an invite to the org.
To be honest I have never written unit tests extensively in C++ (or any other language actually) and yet here we are 😅 |
i've been using doctest for about two years now, and it is critical to my Notcurses project. i'm well-versed in C++ and have deployed it on all major platforms. i maintain doctest for FreeBSD, Fedora, Alpine, and probably one or two i've forgotten about. i'm not in a position to further develop it, really, but i'm happy to maintain it and corral bugfixen. |
@dankamongmen Thanks a lot! Just sent you an invite to the org )) |
@dankamongmen : My offer stands, so if I can be of assistance, feel free to ask. |
Thanks for the offer, but I don't think I'm the right person, I wouldn't have enough time for this. And actually I can't even push to github nowadays... |
Hi @onqtam, thanks for the offer! Also thanks to you for establishing such a cool testing framework, I used it quite a lot in the last year and I really like it! |
I'll provide some details for what I'd hope for the framework because otherwise
The most important thing IMO would be to keep the framework relevant and working - anything else on top of that is a bonus. If there's motivation - workflows for managing/triaging/labeling issues & PRs can be agreed upon. Release processes can be improved. Testing could be more thorough. If there are 4-5 people that monitor issues & PRs - that ought to be enough to not have anything unresponded to for more than a month or 2 and also having a second opinion on things is nice. I'm not sure a lead role is necessary, but if someone turns out more active/competent and others are OK with them - why not. Also, work/roles can be divided - for example:
I've had only one encounter where someone stubbornly insisted on something that I didn't agree with (practicality versus UB maximalism related to forward declarations of std types) but hopefully we're all adults here :) Doctest has carved a niche for itself and is providing value to a surprising number of companies & projects - it would be a waste to simply abandon it - thanks to anyone who participates! I also think that finding some actual funding for it is possible, although I did fail when I tried contacting a few specific companies... Any initiative on that front is to be encouraged! |
@eyalroz If you'd like to participate in any way - even just occasionally as explained above - I'd love to invite you to the org :) @philbucher Yep, busy is the norm :) Thanks for agreeing - adding you to the org! @u3shit - no problem, thanks for responding! :) |
@onqtam your outline of expectations and duties correlates quite closely with the level of effort i was expecting to volunteer, good deal. |
as in, i primarily intend to jump on build issues should/when they surface, and wrangle submitted PRs |
@onqtam : Do invite me then. |
The maintainer onqtam moved the doctest project to a dedicated organization. (doctest/doctest#554) This change makes it so that downloads do not have to rely on redirects.
@Saalvage has stepped up in the past couple of weeks and has contributed quite a few near-perfect PRs and helped solve non-trivial issues - I've been chatting with him and he has agreed to maintain doctest for the foreseeable future! I'll still be around for questions when pinged directly with @onqtam or in Discord (he is there as well), but I won't be reviewing code actively & answering issues going forward unless asked. I'm releasing a new version which fixes some problems which were recently introduced - |
* doctest: Update url's to new doctest organization The maintainer onqtam moved the doctest project to a dedicated organization. (doctest/doctest#554) This change makes it so that downloads do not have to rely on redirects. * doctest: avoid runing cross compiled exe in doctest_discover_tests doctest provides a convienience macro called "doctest_discover_tests" which querries the available test-cases by trying to run the executable. This should not be done durring a cross compile.
Well, it seems that this issue will have to be reopened to draw more attention by potential maintainers. I'll have less bandwidth for onboarding compared to in the past, but will do my best. The good thing is that the library is in a very stable state and most new issues & PRs (from the past 1 year) are either trivial/easy or very niche - it's not going to be a high load for maintenance! Some big company that uses it should cough up 1-2k$ a month for this and other similar projects so that someone maintains them. |
Working on doctest has taught me two very important lessons: how to prioritize and how to say no, and now it's time to apply them to my life. I can no longer maintain doctest properly and that's evident by my inactivity for the past 8 months - I haven't touched C++ professionally in almost 2 years and I've moved on to other things.
I invite anyone interested in the development & maintenance of the framework to join the Discord server. I just moved doctest to a GitHub organization as suggested here and will add whoever is interested as a member. I'll release a version or two and will stick around for some time as people join in order to resolve any disputes and respond to questions and at some point, I'll promote the ones that have shown the most interest to admins & owners of the repository and the Discord server - I won't leave but I hope that by that time others would be able to reach consensus on contentious issues and I'll redirect any donations to the maintainers once this transition period is over.
Doctest doesn't require too much work (unless new features are added) - mostly the occasional compiler bugfix & support in issues. The design goals of the framework should be followed - what made doctest successful is the art of saying no and keeping it light & easy to use.
EDIT: some more info - #554 (comment)
Best regards,
Viktor
The text was updated successfully, but these errors were encountered: