-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimistic rule for post-Bellatrix forks #3390
Comments
To clarify the fork difference in the presentation:
I prefer (1) here because it's more future-proof. /cc @paulhauner What do you think? |
Although, the execution is always enabled for forks post-Bellatrix, and I can understand why we'd want to change the spec, i am curious when this situation occurs on practice? If EL returns Alternative fix is to return if block.slot == GENESIS_SLOT + 1 and is_execution_block(block):
return True |
Though I like more first solution, it looks cleaner, what will happen if we have Bellatrix/Paris genesis start? It's a similar case probably and only @mkalinin's fix will pass. |
Currently we have this check in https://github.com/ethereum/consensus-specs/blob/dev/sync/optimistic.md#helpers
It will fail for first slot (check on parent, which is genesis) in networks starting from post-Bellatrix forks, like Capella or Deneb. I think this rule should be updated to be true in any post-Bellatrix fork without any checks.
The text was updated successfully, but these errors were encountered: