Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipv6 address used as extip results in 127.0.0.1 being used #29736

Closed
wants to merge 5 commits into from
Closed

ipv6 address used as extip results in 127.0.0.1 being used #29736

wants to merge 5 commits into from

Conversation

smin-k
Copy link

@smin-k smin-k commented May 8, 2024

Fix #29495.

Add a condition to the IP() function to check if ip4 is the local host.
Prefer ip6 over localhost.

@smin-k smin-k requested review from fjl and zsfelfoldi as code owners May 8, 2024 12:10
@smin-k
Copy link
Author

smin-k commented May 9, 2024 •
edited 

[user@user]$ ./build/bin/geth --nodiscover --maxpeers 0 --nat extip:1050:0:0:0:5:600:300c:326b -goerli console
INFO [05-09|19:08:13.329] New local node record                    seq=1,715,165,299,988 id=3fe08aae98fe901d ip=1050::5:600:300c:326b udp=0 tcp=30303
INFO [05-09|19:08:13.330] Started P2P networking                   self="enode://097502837e94b3542b6d796f08fba193adc5c932e3d3875fb276e749aca4a39217fabc8fd34566581423329c61d49778d4f6bd563d6d3e3f8b3eacb64034aff1@[1050::5:600:300c:326b]:30303?discport=0"

@fjl
Copy link
Contributor

fjl commented May 16, 2024

I'm working on a more comprehensive alternative fix for this.

@fjl fjl mentioned this pull request May 17, 2024
Open
@fjl
Copy link
Contributor

fjl commented May 17, 2024

Here it is: #29801

@fjl fjl closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl Awaiting requested review from fjl fjl is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipv6 address used as extip results in 127.0.0.1 being used
2 participants
@smin-k @fjl