Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTChecker: add insufficient funds verification target for CHC engine #15086

Conversation

pgebal
Copy link
Collaborator

@pgebal pgebal commented May 8, 2024

changes:

  • add target for CHC engine that verifies balance

Closes #15015

@pgebal pgebal force-pushed the smtchecker/add_insuffienct_funds_veri_target_for_chc branch 4 times, most recently from 433cdb5 to 7f0db84 Compare May 9, 2024 11:48
@pgebal pgebal marked this pull request as ready for review May 9, 2024 11:51
@pgebal pgebal force-pushed the smtchecker/add_insuffienct_funds_veri_target_for_chc branch from 7f0db84 to 3c5aa3b Compare May 9, 2024 11:53
@pgebal pgebal marked this pull request as draft May 9, 2024 14:43
@pgebal pgebal added the smt label May 9, 2024
@pgebal pgebal force-pushed the smtchecker/add_insuffienct_funds_veri_target_for_chc branch from ce2a40e to 10a5df8 Compare May 10, 2024 12:00
Copy link
Contributor

@blishko blishko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!
What else is needed to be ready for review (not draft)?

@pgebal pgebal force-pushed the smtchecker/add_insuffienct_funds_veri_target_for_chc branch 3 times, most recently from 4d1e926 to 899f237 Compare May 13, 2024 19:48
@pgebal pgebal marked this pull request as ready for review May 13, 2024 19:48
@pgebal
Copy link
Collaborator Author

pgebal commented May 13, 2024

This looks good! What else is needed to be ready for review (not draft)?

I had to update a couple tests. Now it's ready for a review/merge.

@pgebal pgebal force-pushed the smtchecker/add_insuffienct_funds_veri_target_for_chc branch 3 times, most recently from f0c8c93 to f59fd0b Compare May 14, 2024 10:59
@pgebal pgebal force-pushed the smtchecker/add_insuffienct_funds_veri_target_for_chc branch from f59fd0b to febe38a Compare May 14, 2024 11:11
Copy link
Contributor

@blishko blishko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blishko blishko merged commit 59cc93e into ethereum:develop May 14, 2024
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMTChecker: Incorrectly determines insufficient balance.
2 participants