Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of Assert in Quick Glossary need to be modified. #1144

Open
godtaehee opened this issue Aug 5, 2022 · 0 comments
Open

Definition of Assert in Quick Glossary need to be modified. #1144

godtaehee opened this issue Aug 5, 2022 · 0 comments

Comments

@godtaehee
Copy link

godtaehee commented Aug 5, 2022

Hello all.

Assert
In Solidity, assert(false) compiles to 0xfe, an invalid opcode, which uses up all
remaining gas and reverts all changes. When an assert() statement fails, some‐
thing very wrong and unexpected is happening, and you will need to fix your
code. You should use assert() to avoid conditions that should never, ever occur.

This is the definition of Assert in ethereum book's Quick Glossary part.

I wonder this below sentence is true:

In Solidity, assert(false) compiles to 0xfe, an invalid opcode, which uses up all
remaining gas and reverts all changes.

After Byzantium Fork, if transaction is failed or some error occurred in smart contract, they are stopped and not consume all the gas paid for a transaction.

So, I think this sentence need to be modified.

Anyone advice ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant