Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing f prefix on f-strings #607

Open
code-review-doctor opened this issue Apr 23, 2022 · 0 comments · May be fixed by #608
Open

Missing f prefix on f-strings #607

code-review-doctor opened this issue Apr 23, 2022 · 0 comments · May be fixed by #608

Comments

@code-review-doctor
Copy link

Some strings looks like they're meant to be f-strings but are missing the f prefix meaning variable interpolation won't happen.

pyre-check/client/dataclasses_merge.py

Line 144 in 5fa00d5

"merge policy. Got `{base}`."

pyre-check/client/dataclasses_merge.py

Line 149 in 5fa00d5

"merge policy. Got `{override}`."

pyre-check/tools/generate_taint_models/__init__.py

Line 74 in 5fa00d5

raise ValueError("No file at `{path}`")

I found this issue automatically. I'm a bot. Beep Boop 🦊. See other issues I found in your repo here
@code-review-doctor code-review-doctor linked a pull request Apr 24, 2022 that will close this issue
Open
@tinin1994 tinin1994 assigned tinin1994 and unassigned tinin1994 Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Missing f prefix on f-strings fix code-review-doctor/pyre-check
2 participants
@tinin1994 @code-review-doctor