-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding lessons for else if to pyramid project #54830
feat: adding lessons for else if to pyramid project #54830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good Jess ! just a few spelling mistakes here and there. Good work 👍
...22/learn-introductory-javascript-by-building-a-pyramid-generator/660f44f10ea40f300b896a5e.md
Outdated
Show resolved
Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/660f44f10ea40f300b896a5e.md
Show resolved
Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/660f44f10ea40f300b896a5e.md
Show resolved
Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664599653fcd6e97104f9261.md
Outdated
Show resolved
Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/660f530d6e33d159e1bf4947.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joy Shaheb <khondokoralam@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting nitpicks.
...22/learn-introductory-javascript-by-building-a-pyramid-generator/660f44f10ea40f300b896a5e.md
Outdated
Show resolved
Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/66458f0a05df478aa627629e.md
Show resolved
Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664599653fcd6e97104f9261.md
Outdated
Show resolved
Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664599653fcd6e97104f9261.md
Show resolved
Hide resolved
Co-authored-by: Lasse Jørgensen <28780271+lasjorg@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't really know where to put this, but the assert.equal(done, 0);
on line 55 of step 77 should be a strictEqual
so you can't pass with the string "0"
...22/learn-introductory-javascript-by-building-a-pyramid-generator/66458f0a05df478aa627629e.md
Outdated
Show resolved
Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664599653fcd6e97104f9261.md
Outdated
Show resolved
Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664599653fcd6e97104f9261.md
Outdated
Show resolved
Hide resolved
...22/learn-introductory-javascript-by-building-a-pyramid-generator/664599653fcd6e97104f9261.md
Outdated
Show resolved
Hide resolved
…github.com/jdwilkin4/freeCodeCamp into curriculum-if-else-lessons-pyramid-project merge latest changes
It did just dawn on me that switching the order of teaching So teach First
Then
That makes it more clear that Anyway, I can approve this and we can revisit it later if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think switching the order is something to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
I think the text makes it sound like multiple if statements are the same as a
Maybe we can nest the new Seed code:
Solution:
This needs to be changed as well somehow.
So, maybe something like:
|
I have reverted the changes back the way it was before the if, else if switch. I vote we merge this in as is. |
Sure, we can do that. Anyway, here is one way we might write the instructions.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test it, but if this just reverts to what it was before, then I already approved that.
Summary
The first review project mentions that else if statements were taught in the pyramid. But that ins't the case, So this PR adds that lesson.
Checklist:
main
branch of freeCodeCamp.Closes #54825