Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Update Zap Android instructions #386

Merged

Conversation

louneskmt
Copy link
Contributor

@louneskmt louneskmt commented Sep 19, 2021

Tor is now built-in, updating the instructions to remove the use of Orbot. Also adapting to new setup process (button name, hostname validation, certificate included).

Tested both processes (QR code scanning and paste lndconnect string) on Zap 0.5.1-beta build 3031 on my test phone.

Resolves #385.
Resolves getumbrel/umbrel#981.

@lukechilds lukechilds merged commit df8ea0d into getumbrel:master Oct 7, 2021
@michaelWuensch
Copy link

@louneskmt Uhm why did you include the certificate again? We don't need it on tor. It just makes the QR code too large for some devices to scan it.

@louneskmt
Copy link
Contributor Author

@michaelWuensch If I remember well, I got an error telling me that the lndconnect string didn't match a regex including "?cert=". Let me try again.

@michaelWuensch
Copy link

@louneskmt Zap android does definetly not require a cert when connecting to a .onion node.
It workes in the Umbrel 4.3 version without the certificate.
We actually removed the certificate a while ago on the connection screen aa people had issues scanning the dense QR Code.
If you have a specific error message and need help, please let me know.

@louneskmt
Copy link
Contributor Author

louneskmt commented Oct 8, 2021

@michaelWuensch Yeah, not sure why I've faced this error. It must have been something else than the missing certificate. I'll make a PR this afternoon to correct that, sorry 😁

@lukechilds
Copy link
Member

lukechilds commented Oct 8, 2021

Thanks for the heads up @michaelWuensch! Will wait for the follow up PR before adding it to Umbrel.

lukechilds added a commit that referenced this pull request Oct 8, 2021
@jamescridland
Copy link

I'm confused at the above - Zap Android simply does not require anything further to set it up other than to scan the QR code. I've just used it now on Umbrel v.0.4.7 - Orbot is absolutely not required.

Regardless of the need of a cert or not within the QR code, could we please remove the erroneous advice to install Orbot? It's absolutely not required.

@michaelWuensch
Copy link

Any news on this? Really all that needs to be done is removing the first 4 steps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Zap Android connection instructions [Correction] Zap Android connection instructions
4 participants