-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: make.bash fails for GOOS=plan9 GOARCH=386 #67502
Comments
It looks like it's broken since CL 577935. |
This change works around the issue:
The question is now why it doesn't work for plan9/386? |
Change https://go.dev/cl/586775 mentions this issue: |
The plan/386 port doesn't bootstrap at this time. Remove it from the current misc-compile trybot set to get them passing while the Plan 9 issue is being investigated and fixed. For golang/go#67502. Change-Id: Ie7bb48c9efd3e82bf72a18ac976e609d795d5c81 Reviewed-on: https://go-review.googlesource.com/c/build/+/586775 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Change https://go.dev/cl/586835 mentions this issue: |
CL 577935 enabled hot block alignment on 386 and amd64 architecture. However, this change broke the plan9/386 build. This change disables AlignHot on plan9/386. Updates #67502. Change-Id: If73b066824c7218a9408c6e8f06aec5908b7a64f Reviewed-on: https://go-review.googlesource.com/c/go/+/586835 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com> Run-TryBot: David du Colombier <0intro@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Change https://go.dev/cl/589656 mentions this issue: |
The bootstrap failure is now resolved via CL 586835, which is what the original report was about. Perhaps it would work well to close this issue and open a separate one to investigate why AlignHot breaks plan9/386 bootstrapping, and possibly track re-enabling it. |
CL 586835 made "disabled due to go.dev/issue/67502" no longer apply, so bring it back. For golang/go#67502. Change-Id: Ibe22740f155f46da7ae6ae2ea0087b51e3e99b7b Reviewed-on: https://go-review.googlesource.com/c/build/+/589656 Reviewed-by: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David du Colombier <0intro@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
As reported by the plan9-386-0intro builder and legacy misc-compile-plan9-386 trybot, the plan9/386 port fails to bootstrap:
Also see https://build.golang.org/log/f237bed35a32f61819468d4cfd1b28946cb3e4d1 and https://storage.googleapis.com/go-build-log/ecc40e66/misc-compile-plan9-386_f210191c.log.
This doesn't happen for other ports. It also doesn't happen for other GOARCH values of GOOS=plan9 like plan9/amd64 and plan9/arm, only for plan9/386.
CC @golang/plan9.
The text was updated successfully, but these errors were encountered: