Explore: Add a query template to query library from query history #88047
Conversation
…ery-history # Conflicts: # public/app/features/explore/RichHistory/RichHistoryCard.tsx
ifrost
requested review from
joshhunt and
JoaoSilvaGrafana
and removed request for
a team,
joshhunt and
JoaoSilvaGrafana
| variant="secondary" | ||
| aria-label={buttonLabel} | ||
| onClick={() => { | ||
| handleAddQueryTemplate({ title: 'Test', targets: [query] }); |
There was a problem hiding this comment.
I know this will get replaced later, but I'd like the title field to be optional, could we have a better default here? Like "Imported from Explore - {timestamp}" or something?
There was a problem hiding this comment.
but I'd like the title field to be optional,
By optional you mean so the user can leave the input blank and then it'd default to "Imported from Explore - {timestamp}"?
cc @diegoadams. Not sure if we've discussed. In your designs - is the description field required or would default to something it the description is not provided? If we fallback to a default, what's the best way to show it to the user? With a placeholder in the input field?
There was a problem hiding this comment.
Great! Already approved but now I EXTRA approve :D
ifrost
added
no-backport
|
@ifrost , if I'm understanding this correctly, I would say that it is not required. this is an example of queries that have and done have descriptions. 
|
Fixes #88042
Screen.Recording.2024-05-20.at.13.06.26.mov