Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show search as find in page, not in a popup #2164

Open
4 tasks done
dcdom2 opened this issue Nov 26, 2023 · 1 comment
Open
4 tasks done

Show search as find in page, not in a popup #2164

dcdom2 opened this issue Nov 26, 2023 · 1 comment

Comments

@dcdom2
Copy link

dcdom2 commented Nov 26, 2023

⚠️ This issue respects the following points: ⚠️

  • This is a enhancement/feature request. Not a bug or question.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The wanted feature/enhancement is not present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor's settings are not touched. If your desired feature is present, you don't need to open this issue. The change will be part of the next Markor update.)

Description

Currently:

  1. search term is lost when selecting a result line.
  2. you can't see results in context (within preceding/succeeding lines).

Both should improve if it is shown as a browser find in page feature that preserves the search query.

The current popup can still be accessible though a button or so.

Information

App Version: 2.11.1

Source

F-Droid

Format / File type

Not specific

Additional info / Log

No response

@harshad1
Copy link
Collaborator

Fundamentally, the issue is that

search term is lost when selecting a result line.

Keeping this alive somehow is an 80% solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants