Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asciidoc :icons implementation #2172

Open
4 tasks done
Pyblo opened this issue Nov 26, 2023 · 4 comments
Open
4 tasks done

Asciidoc :icons implementation #2172

Pyblo opened this issue Nov 26, 2023 · 4 comments
Assignees

Comments

@Pyblo
Copy link

Pyblo commented Nov 26, 2023

⚠️ This issue respects the following points: ⚠️

  • This is a enhancement/feature request. Not a bug or question.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The wanted feature/enhancement is not present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor's settings are not touched. If your desired feature is present, you don't need to open this issue. The change will be part of the next Markor update.)

Description

  1. I would like for implementation of asciidoc icons icon:heart[role=red]. That would help greatly, since icons can be colored and have many great inline formating features.

It would great if the :icons: font mode worked, but having at least the :icons: svg + :iconsdir: ./icons mode worked.

Information

Android version: 11
Device: xiaomi Mi 10 lite 5g
App Version: v2.11.1(148)

Source

F-Droid

Format / File type

Something else (-> Additional info)

Additional info / Log

- it is for Asciidoc format 
- currently we can use the svg image:{icon_name} as a workaround, but it lacks colouring and using it inline is not straightforward.
@Pyblo
Copy link
Author

Pyblo commented Nov 29, 2023

While testing all the other icon implementation on with Asciidoctor, i noticed, that The only way to go is using :icons: font. Unfortunately all other modes display icons that are not properly sized to the text size in lines.

@gsantner
Copy link
Owner

gsantner commented Dec 3, 2023

Please feel free to work on it and create a merge request to make the improvements available to others.

@gsantner
Copy link
Owner

notice: @aisbergde implemented most of asciidoc support, so assume have an good idea about this too.

@aisbergde
Copy link
Contributor

I only implemented the formatting support in the editor mode (plain text). The preview was implemented by someone else. Is the request related to the preview or to the formatting while editing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants