Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default behaviour for handling links to .html files #2201

Open
gnomy47 opened this issue Jan 9, 2024 · 2 comments
Open

Change the default behaviour for handling links to .html files #2201

gnomy47 opened this issue Jan 9, 2024 · 2 comments

Comments

@gnomy47
Copy link

gnomy47 commented Jan 9, 2024

IMPORTANT

  • App version: 2.11.1 installed from the F-Droid Repository
  • Android version/rom: Android 13
  • Device: Google Pixel 4a
  • I accept that this issue will be closed without further notice in case I didn't describe the problem including general information, or didn't search for similar issues & requests.

Explain the Problem

The issue I have

  1. Add a link to a local HTML file in a markdown note in Markor
  2. Switch to the view mode in Markor and then tap on the link added above
  3. Markor will show the HTML code of the file

My request

I would like Markor to either prompt me to open a link to a local HTML file in my web browser or simply open it in the webview like it does for regular URL links.

Screenshots for additional explanation

The image below shows an example of a markdown file with links to a .html file and a .pdf file.

01

When I open the link to the .html file, Markor handles it as a HTML code file -

03

When I open the link to the local PDF file, I am prompted to open it with an external application -

02

I would like a similar prompt for links to local HTML files as well.

Additional Context and Usecase

I often use the SingleFile Firefox extension to save blog posts, articles, guides etc., so that I can read them later. Then I add links to such .html files in my personal notes for future reference.

I should also add that unlike what is shown in the second screenshot above, most of the time Markor simply freezes when I open a link to such a .html file saved with the SingleFile extension and then I have to force kill the app. Otherwise I could have simply used the "Open With" action button and this would not be an issue. (I have checked that this is not an issue with the .html files saved by the SingleFile extension because the same files open without any issue with any web browser application.)

I'm not aware if Markor intends to be an application for HTML coding but from what I understand, the preference under "Settings > General > Always open with this app" can already let a user open .html files with Markor if specified. Therefore, even if the default behaviour to handle .html files was changed to open them in webview, it should not be a problem for those who prefer the current behaviour?

I hope I was able to make the issue clear to understand. Thank you for creating this wonderful application.

@gsantner
Copy link
Owner

gsantner commented Jan 9, 2024

The hang is likely due long data: uris and big files.

Improvements are welcome.

@gnomy47
Copy link
Author

gnomy47 commented Jan 10, 2024

The hang is likely due long data: uris and big files.

Yes, that seems to be the case.

Improvements are welcome.

Unfortunately I'm just a student with no coding skills. I would like to request for this issue to stay open in case someone else decides to work on it.

Thank you once again for this application, it is easily one of the most useful apps on my phone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants