Bug Report: Delayed Appearance of Newly Created Folders

[XYIheng]

⚠️ This issue respects the following points: ⚠️

• This is a bug. Not a question or feature request.
• The topic is not already reported at Issues. (I've searched it).
• Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
• The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

In the markor, when creating a new folder, the new folder does not appear immediately. The delayed appearance of the newly created folder causes confusion and disrupts the expected user experience.

Steps to reproduce

1. click FAB
2. rotate device
3. enter the folder name
4. click Folder
5. see error: the created folder doesn't appear, and you need to refresh the app to let the folder appear

bug_create_folder.mp4

Information

Android version: Android 10
Device: pixel2 and pixel 7
App Version: 2.11.1

Source

F-Droid

Format / File type

Not specific

Additional info / Log

-

[gsantner]

please download test builds from https://github.com/gsantner/markor/actions?query=branch%3Amaster+actor%3Agsantner if you didnt already - click the latest build and you can find a android-apk button to download. Is it better in Marder?

[XYIheng]

@gsantner Hi, I just download the latest build apk from your link and find the bug still exists

[gsantner]

In Marder? (If you check Markor you dont use the version from that apk)

[XYIheng]

@gsantner Yes, in Marder.

[XYIheng]

20240328_162027.mp4

Also not work when try to create new files

[gsantner]

Humbly said, I can not reproduce on release nor testversion. New stuff shows up after accepting.

[XYIheng]

Humbly said, I can not reproduce on release nor testversion. New stuff shows up after accepting.

Hi, I downloaded Marder from this link https://github.com/gsantner/markor/actions/runs/8483832311
And tested it on my real device: Xiaomi 10s, MIUI14.0.6.
The bug still exists

[XixianLiang]

I can also reproduce this bug.
apk version (the one that @XYIheng mentioned above): https://github.com/gsantner/markor/actions/runs/8483832311

HUAWEI HONER
Android: 12
OS: MagicOS 7.0
Model: AGT-AN00

[gsantner]

Feel free to fix the issue and create a merge request. Thanks!

[harshad1]

I have traced this bug.

We pass a callback into the NewFileDialog to be triggered when the dialog completes. Upon rotation, the dialog is recreated and the callback is invalidated.

We need to either preserve the callback (difficult) or change how we trigger whatever we want to trigger after the dialog is complete.

[harshad1]

Ok, the solution was simple. I have it included here - https://github.com/gsantner/markor/pull/2275/files

[gsantner]

closed by #2277