Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.12.1: Markdown Table of Contents behavior changed since v2.11.0 #2296

Closed
4 tasks done
izzytechie opened this issue May 19, 2024 · 1 comment · Fixed by #2300
Closed
4 tasks done

v2.12.1: Markdown Table of Contents behavior changed since v2.11.0 #2296

izzytechie opened this issue May 19, 2024 · 1 comment · Fixed by #2300
Assignees
Milestone

Comments

@izzytechie
Copy link

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

When viewing a Markdown file, the user can tap on the name of the file at the top to open a Table of Contents window listing the headers in the file. Tapping on one of the headers takes the user to the header within the file.

In v2.11.0, after tapping on the header, the Table of Contents window automatically closes. This is the desired behavior.

In v2.12.0, after tapping on the header, the Table of Contents window does not automatically close. The user has to tap on Cancel at the bottom of the window to close the window. This is not the desired behavior.

Steps to reproduce

  1. Open a Markdown file containing headers.
  2. Tap on the name of the file at the top to open a Table of Contents window listing the headers in the file.
  3. Tap on one of the headers in the Table of Contents window to go to the header within the file.
  4. Observe that the Table of Contents window does not automatically close.

Information

Android version: 10
Device: Oukitel C21
App Version: 2.12.0

Source

Google Play

Format / File type

Markdown

Additional info / Log

-
@harshad1
Copy link
Collaborator

This is fixed in #2300

@gsantner gsantner linked a pull request May 25, 2024 that will close this issue
@gsantner gsantner added this to the Markor v2.13 milestone May 25, 2024
@gsantner gsantner changed the title Markdown Table of Contents behavior changed between v2.11.0 and v2.12.0 v2.12.1: Markdown Table of Contents behavior changed since v2.11.0 May 25, 2024
gsantner added a commit that referenced this issue May 25, 2024
…#2303 closes #2296 closes #2297)

* Headline Dialog State
* Fixes with format order and type
* Switching to list for ease of use

---------

Co-authored-by: Gregor Santner <gsantner@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants