-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
24.03: byte_slice(): Byte range out of bounds #10497
Comments
I know where in the code the crash occurs but I can't find anything wrong with it so we need more Information:
|
|
Does your document contain carrige return (CR) linenedings (just I think that's the most likely explanation for this and in that case I know how to fix this. |
Hmm nevemind I guess I don't see crashes with CR in testing. I thought tree sitter counted those as newlines but we didn't. Not sure what exactly this is causing that it's pretty weird and I can't reproduce. |
I checked file and are all I have set the env Can you increase the log verbosity? Maybe to see all commands/keybinds? |
|
@krukas are you running any patches? I get this issue all the time because of some underlying bug that's exposed undo/redo and a patch I have that keeps the editor in insert mode always, but I've not bothered to rebase my fork & debug. Also note that a fix for similar issue (#6645) was merged just after the 24.3 release. Maybe try that out? |
The panic message will not tell you anyrhing. If anyrhing goes wrong in the editor it usually ends up in a panic like that. I know what code is causing it and there is very little that can go wrong there (nothing related to undo or the rendering system). Tree sitter ir producing an invalid point offset/we are reading it. I will probably just fix this by removing the use of tree sitter points entirely and just always use byte positions instead |
I'm running 24.03 from Opensuse tumbleweed repo, don't know if some patches are applied to that. |
Oops, I misread the panic message... 馃う that other issue is not similar, never mind. |
had another crash after I selected text with mouse and used space+y, could not reproduce and this time it was a small The file in question:
|
Summary
Just starting to use Helix and love it 馃憦
Today i had two crashes, hard to pinpoint what was happening or reproduce. both time did an undo and then go into insert mode.
Reproduction Steps
No response
Helix log
~/.cache/helix/helix.log
Platform
Linux
Terminal Emulator
Alacritty with zellij
Installation Method
zypper (OpenSuse tumbleweed)
Helix Version
helix 24.3 (2cadec0)
The text was updated successfully, but these errors were encountered: