Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nix,holonix): use the rust-toolchain.toml for all rust packages #3759

Open
1 task
steveej opened this issue Apr 26, 2024 · 2 comments
Open
1 task

feat(nix,holonix): use the rust-toolchain.toml for all rust packages #3759

steveej opened this issue Apr 26, 2024 · 2 comments
Labels
automation Continuous integration issues and other automation improvements enhancement New feature or request

Comments

@steveej
Copy link
Member

steveej commented Apr 26, 2024

  1. initialize rust-toolchain.toml into each of the rust projects' repositories with the currently used rust toolchain, e.g. 1.77.0.
  2. use rust-overlay's fromRustupToolchainFile to assemble the toolchain
  3. optional but encouraged: ensure holonix only contains a single desired (holochain's?) toolchain ([BUG] Entering a coreDev shell fetches a Rust compiler we don't need #3696)

open questions:

  1. should holonix support reading from the end-users project's rust-toolchain.toml or whether use holochain's version?
@steveej steveej added enhancement New feature or request automation Continuous integration issues and other automation improvements labels Apr 26, 2024
@ThetaSinner
Copy link
Contributor

Bullet 3. possibly overlaps with -> #3696

Copy link
Contributor

This item has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label May 27, 2024
@abe-njama abe-njama removed the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous integration issues and other automation improvements enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants