Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The release automation produces TOML which is not correctly formatted #3802

Open
ThetaSinner opened this issue May 1, 2024 · 1 comment
Open

The release automation produces TOML which is not correctly formatted #3802

ThetaSinner opened this issue May 1, 2024 · 1 comment
Labels
automation Continuous integration issues and other automation improvements

Comments

@ThetaSinner
Copy link
Contributor

ThetaSinner commented May 1, 2024 •
edited by jost-s

All toml files are checked on CI for formatting with taplo since recently. The release automation applies a different formatting for all the released Cargo.tomls and breaks tests on CI after a release.

Formatting can be fixed either in the release automation or running taplo format after a release.

AC:

  • formatting is consistent with taplo format --check
@ThetaSinner ThetaSinner added the automation Continuous integration issues and other automation improvements label May 1, 2024
This was referenced May 1, 2024
Closed
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 1, 2024

This item has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label Jun 1, 2024
@abe-njama abe-njama removed the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation Continuous integration issues and other automation improvements
Projects
Holochain Core
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThetaSinner @abe-njama