-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflows review 2nd iteration #3866
Comments
It looks like you added some of what it does later in this bullet. But yes, it is still relevant. We want the validation workflow to be complete as soon as the validation status fully determined (valid / rejected). However, there are follow-up async actions that should not be a part of the validation workflow, such as sending validation receipts and/or warrants. So some workflow must follow validation, whether it is called "integration" or not can be discussed. Also, I want to note that a timestamp for the moment of final validation / integration is vital to the integrity of gossip which should be just asking for "what's new since time x" as your last integration timestamp you've already gossiped with them. This is something we should confirm is happening. |
I'm referring to the status quo. There are 4 database updates it performs and it's not obvious what they're for. Upon checking now I see that the integration workflow triggers a validation receipt workflow. That should be part of the review too. |
There are more parts of the workflows which need review.
The text was updated successfully, but these errors were encountered: