Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aspect_ratio code error in this repository #407

Closed
oceanogeology opened this issue May 16, 2024 · 0 comments
Closed

aspect_ratio code error in this repository #407

oceanogeology opened this issue May 16, 2024 · 0 comments

Comments

@oceanogeology
Copy link

https://github.com/hpcaitech/Open-Sora/blob/ea41df3d6cc5f389b6824572854d97fa9f7779c3/opensora/datasets/aspect.py#L325C20-L325C26

aspect_ratio = height / width

should be

aspect_ratio = width /height

@oceanogeology oceanogeology changed the title get_closest_ratio code error aspect_ratio code error in this repository May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant